Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
tt-a1i
left a comment
There was a problem hiding this comment.
Review:Changes Requested
固定版本 e5c54204c9ce1a7f8afe7b343fec5a1b7b404eb9。
问题 / 价值 / 方法
将模型能力与 Harness 强度的比较整理为研究协议,明确身份、隔离、指标和解释门槛,减少后续实验口径漂移。仅改两份 Markdown;没有新增 runtime、工具或配置,保守解释方向合理。
Standards
1 项 P2:2026-08-30 新建文档误放入早于 Decision 0001 的 Legacy records,见索引行内意见。
Spec
1 项独立 P2:新增 profile 对照替换了来源中的实验安排,未注明为新建议,见正文行内意见。Spec 也发现了上述 Legacy 归类问题。
非阻塞:明确四臂反转/配对的含义,并补 Issue 回链和适用来源信息。
不要求在这份研究协议中补做正式 Benchmark,也不要求上传原始日志或改变默认 runtime。
验证
该 exact head 的隔离工作树中:frozen-lockfile 安装后 bun run check 通过;git diff --check 和4个本地 Markdown 链接检查通过。两路规范/Spec 审查已完成。没有重跑全量 tests 或模型实验,仓库检查不能证明研究结论。现有 CI 绿色,分支落后 main。
本次仅提交 review,未改文件、未合并。
Code Review SummaryChanges Requested:2 项 P2。 完整 review,审查版本
隔离 checkout 的 |
tt-a1i
left a comment
There was a problem hiding this comment.
Reviewed repaired head 0a534d0. Standards and Spec: the scoped P2 findings are addressed; no remaining P0/P1 or actionable small defect identified. Repository check and full-suite evidence are recorded in this review batch; targeted regressions cover the repair where applicable. This replaces my earlier findings against the old implementation. I pushed the repair, so this approval does not constitute the independent approval required after the last push. Current-head CI, current-main integration, and that independent approval remain merge gates.
# Conflicts: # docs/research/README.md
Problem
Issue #45 has a detailed cross-harness investigation, but its reusable protocol and evidence boundaries are not represented in the repository research index. This makes it easy to confuse existing observations with a completed benchmark or a runtime decision.
Value
A versioned research record gives future benchmark work a stable, reviewable contract for model/harness identity, paired execution, usage accounting, failure classification, and conservative interpretation. It keeps OpenPI's Pi-native default intact until evidence supports a change.
Approach
docs/research/OPENPI_HARNESS_STRENGTH_PROTOCOL_2026-08-30.md.Validation
git diff --check— passed.npx --yes bun@1.3.14 run lint— passed.npx --yes bun@1.3.14 run typecheck— passed.docs/README.mdanddocs/research/README.md; Biome intentionally ignores Markdown in this repository.Impact
Related to #45